Skip to content

update lora add #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jintao-Huang merged 1 commit into from
May 27, 2026
Merged

update lora add #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mcore_bridge/tuners/lora.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ def merge(self, safe_merge: bool = False, adapter_names: Optional[list[str]] = N
orig_weights = [weight.data.clone() for weight in orig_weights]
delta_weights = self.get_delta_weights(active_adapter)
for orig_weight, delta_weight in zip(orig_weights, delta_weights):
orig_weight += delta_weight
orig_weight.data += delta_weight

@gemini-code-assist gemini-code-assist Bot May 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using the .data attribute is discouraged in modern PyTorch because it bypasses autograd tracking and safety checks, which can lead to silent bugs. To safely perform this in-place addition without triggering autograd errors (since delta_weight may require gradients), you should detach delta_weight using .detach() instead.

Suggested change
orig_weight.data += delta_weight
orig_weight += delta_weight.detach()

if not all(torch.isfinite(orig_weights[i]).all() for i in range(len(orig_weights))):
raise ValueError(
f'NaNs detected in the merged weights. The adapter {active_adapter} seems to be broken')
Expand Down
Loading