Skip to content

feat(cli): add pacman silent install source - #850

Merged
benvinegar merged 1 commit into
modem-dev:mainfrom
marmitar:feat/pacman-install-source
Aug 30, 2026
Merged

benvinegar merged 1 commit into
modem-dev:mainfrom
marmitar:feat/pacman-install-source

Conversation

@marmitar

Copy link
Copy Markdown
Contributor

No runtime detection for pacman, since different AUR packages may install binaries at different locations (/opt, /usr/bin, /usr/lib). Only viable detection is pacman -Qo ${executablePath} or something like rg ${executablePath} /var/lib/pacman/local/*/files.

Both cases could affect startup time, so pacman is only available via the HUNK_INSTALL_SOURCE environment variable. Either bundled with --env "HUNK_INSTALL_SOURCE*" or set at runtime from a custom wrapper.

Because of how pacman packages are managed, no update notices or specific update instructions should be shown.

@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

PR author is not in the allowed authors list.

@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

@marmitar is attempting to deploy a commit to the Modem Team on Vercel.

A member of the Team first needs to authorize it.

@marmitar

marmitar commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Sorry, forgot to mention. I maintain the AUR package hunk and I plan on using it there. I'm using HUNK_INSTALL_SOURCE=mise, but the message don't really make sense there.

@marmitar
marmitar force-pushed the feat/pacman-install-source branch from 32aa94c to 1213173 Compare August 29, 2026 13:47
@marmitar

Copy link
Copy Markdown
Contributor Author

@benvinegar could you please review this? Or implement an equivalent feature?

@benvinegar

Copy link
Copy Markdown
Member

Yep, taking a look, just wrapping my head around what it means to have 2 packages here:

image

@marmitar

marmitar commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

AUR packages are usually built from source, that's what the hunk package does. In contrast, hunk-bin just fetches the pre-built binary from the release page.

The un-updatable pacman install source would make sense for both packages in this case.

Comment thread src/core/process/updateNotice.ts Outdated
* is replaced by rebuilding the checkout it came from, which is the developer's own workflow and
* not something a published version number should interrupt.
*
* AUR packages installed via pacman should be updated manually or via an AUR helper.

@benvinegar benvinegar Aug 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording nit: AUR packages aren’t installed by pacman directly. Could this say “Arch packages installed through pacman or an AUR helper” instead?

This comment was generated by Pi using GPT-5.6 Sol

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment thread .changeset/olive-impalas-nail.md Outdated
"hunkdiff": patch
---

Support pacman/AUR installs via `HUNK_INSTALL_SOURCE=pacman`.

@benvinegar benvinegar Aug 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we clarify that this recognizes pacman/AUR-managed installs rather than adding an installation method? Maybe: “Recognize pacman/AUR-managed installations via HUNK_INSTALL_SOURCE=pacman and suppress automatic update notices for them.”

This comment was generated by Pi using GPT-5.6 Sol

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

No runtime detection for pacman, since different AUR packages may
install binaries at different locations (/opt, /usr/bin, /usr/lib).
Only viable detection is 'pacman -Qo ${executablePath}' or something
like 'rg ${executablePath} /var/lib/pacman/local/*/files'.

Both cases could affect startup time, so pacman is only available via
the 'HUNK_INSTALL_SOURCE' environment variable. Either bundled with
'--env "HUNK_INSTALL_SOURCE*"' or set at runtime from a custom wrapper.

Because of how pacman packages are managed, no update notices or
specific update instructions should be shown.
@marmitar
marmitar force-pushed the feat/pacman-install-source branch from 1213173 to be6f045 Compare August 30, 2026 21:07
@benvinegar
benvinegar enabled auto-merge (squash) August 30, 2026 21:47
@benvinegar
benvinegar merged commit 65d1c20 into modem-dev:main Aug 30, 2026
11 of 12 checks passed
@marmitar
marmitar deleted the feat/pacman-install-source branch August 30, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants