feat(review): add threaded inline comments - #925
Merged
Merged
Conversation
Contributor
|
Too many files changed for review (55 files, 50 file limit). Bypass the limit by tagging |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
benvinegar
force-pushed
the
feat/threaded-review-comments
branch
from
August 30, 2026 19:42
a8e28f4 to
f30af43
Compare
benvinegar
force-pushed
the
feat/threaded-review-comments
branch
3 times, most recently
from
August 30, 2026 20:34
852aeff to
828e5b7
Compare
benvinegar
force-pushed
the
feat/threaded-review-comments
branch
from
August 30, 2026 20:41
828e5b7 to
75338fc
Compare
|
Hi @benvinegar, thanks for adding this great missing feature! I checked it out; however, I noticed an issue entering edit mode using the keyboard only. When navigating with Monosnap.screencast.2026-09-04.10-43-34.mp4As seen on the recording above, even when I hover with the mouse & press I'm using iTerm + tmux - wonder if this has anything to do with it. Am I missing something? Let me know if I can provide you with more information. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Inline reviewer notes could only be created and deleted. Reviewers could not correct a saved note or continue a discussion beside the affected code, which forced context into disconnected notes or external review tools.
Approach
This belongs in review core because thread identity, mutation rules, ordering, and cross-surface parity are shared review semantics. Rendering, mouse hit areas, composer focus, and viewport preservation remain terminal-local.
Important boundaries
stateRevisionremains the concurrency controlVerification
bun run formatbun run typecheckbun run lintbun run deps:checkbun run test: 2,067 passed, 10 skippedbun run test:integration: 136 passed, 1 platform skipbun test test/pty/notes.test.ts: 19 passedbun run test:tty-smoke: 9 passedbun run install:bingit diff --checkPlatforms
Tested on Linux. macOS and Windows were not tested locally; the existing macOS-only PTY lifecycle test remained skipped.
Visual evidence
Validated in the real Hunk TUI through PTY interaction coverage and a local installed-binary TTY transcript smoke. No media is attached.
Release
Includes a minor
hunkdiffChangeset.This PR description was generated by Pi using gpt-5.6-sol