feat(extensions): add pane activation callback - #965
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThe PR adds extension API version 16 with a pane-wide
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issues identified. The public type, registration validation, host event routing, failure containment, documentation, and unit and PTY coverage are aligned for the new pane activation behavior. Important Files Changed
Sequence DiagramsequenceDiagram
participant U as User
participant C as Extension content
participant H as Pane host
participant E as onActivate callback
participant N as Notification sink
U->>C: Primary mouse press
C-->>H: Mouse event bubbles
H->>E: Invoke onActivate()
alt callback succeeds
E-->>H: void or fulfilled thenable
else callback throws or rejects
E-->>H: Error
H->>N: Attributed warning
end
C-->>U: Extension-local interaction continues
Reviews (1): Last reviewed commit: "feat(extensions): add pane activation ca..." | Re-trigger Greptile |
1 task
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onActivate()callback for docked panes<scrollbox>body contentWhy core
Hunk owns the pane rectangle and is the only layer that can reliably observe presses across native OpenTUI scrollbox content. This is a generic focus/active-state capability for extension panes; it adds no integration-specific behavior.
Testing
bun run typecheckbun run lintbun run format:checkbun run deps:checkbun run check:docsbun run changeset:statusbun run test(2,152 passed, 3 skipped)bun run test:integration(140 passed, 1 macOS-only skipped)bun run test:tty-smoke(9 passed)The new PTY fixture exercises the real Hunk TUI at 240x24 in stack layout on Linux and clicks content inside an extension-owned scrollbox. There is no visual styling change, so no before/after media is included. macOS and Windows were not run locally.
Scope
This observes primary presses without changing focus policy itself. OpenTUI scrollbar thumb/track controls remain scrollbar-owned because they intentionally stop mouse propagation.