Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent puppeteer download issues from blocking storybook-builder tests #2892

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

bashmish
Copy link
Member

@bashmish bashmish commented Feb 18, 2025

What I did

  1. prevent puppeteer download issues from blocking storybook-builder tests

puppeteer is not used in storybook-builder tests anyway, so no need to download it, and it's probably better for perf also

Issues look like this, I could only found that it's probably due to some server availability where puppeteer binaries are downloaded from, I saw these multiple times lately, often 2nd restart helped to resolve, so this proves the theory.

image

Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: 20aa027

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bashmish bashmish merged commit 96afc6b into master Feb 18, 2025
8 of 9 checks passed
@bashmish bashmish deleted the fix/puppeteer-blocking-storybook-builder-tests branch February 18, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant