Fix empty WHERE clause in resourcelist TV input (2.x) #16750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes SQL syntax generation in resourcelist TV render when:
Why is it needed?
How to test
The error was observed in MODx version 2.8.8-pl
1. Configuration for resourcelist TV in MIGx
{"allowBlank":1,"showNone":1,"parents":"1,2,3","includeParent":1,"where":[{"published":"1"},{"hidemenu":"0"}],"limit":"0"}Verify:
?a=index&namespace=migx&configs=...)published=1andhidemenu=0are applied correctly2. Standard MODX TV:
resourcelistinput type[{"published":"1"}, {"hidemenu":"0"}]Check resource selection in manager.