Change CMD to use npm start instead of node#2
Merged
Conversation
`node server/server.js` hangs on start
Owner
|
Thanks for catching this and the clean fix! |
Owner
|
@nazgu1 Hey, just wanted to circle back and say thanks again for your help on this. Your suggestion here made a real difference to the project. https://www.instbyte.com/#community Really appreciate the time you put into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like
node server/server.jshangs on start when using docker.To mitigate this issue I've changed CMD in Dockerfile to nom start, so even if start command will be changed in the future Dockerfile will be fine.