Potential fix for code scanning alert no. 65: DOM text reinterpreted as HTML#13
Merged
Conversation
mokesano
added
bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| var link = $(this); | ||
| // Mengembalikan href asli dari data-href | ||
| link.attr('href', link.attr('data-href')); | ||
| link.attr('href', getSafeHref(link.attr('data-href'))); |
…as HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ed as HTML' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mokesano
force-pushed
the
alert-autofix-65
branch
from
657fb05 to
663d814
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/mokesano/editorial-pro/security/code-scanning/65
To fix this safely, validate/sanitize the URL before restoring it to
href, and fall back to a safe value (#) when invalid.Best approach here: add a small helper in
plugins/themes/sangiapub/js/gabungan.jsnear the external-link delay block that only allows safe protocols (http:,https:,mailto:,tel:) and same-page/hash or relative URLs. Then replace line 294 assignment to use this helper.This keeps existing functionality (restoring legitimate external links after load) while blocking dangerous schemes such as
javascript:.Suggested fixes powered by Copilot Autofix. Review carefully before merging.