Skip to content

Fix for build on Windows #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for build on Windows #108

wants to merge 1 commit into from

Conversation

mdhvg
Copy link

@mdhvg mdhvg commented Mar 11, 2025

  • This PR fixes issues in the code that could've lead to undefined behaviours
    • Variable-Length Arrays (VLAs), though supported by GCC and Clang, not recommended for use
float vec[vec_len];
// vec_len being a variable set at runtime.
  • Also, the pthread for windows conversion macro from ggml-org/ggml is added to clip.cpp to enable multi-threading support on Windows.

Copy link

recurseml bot commented Mar 11, 2025

😱 Found 1 issue. Time to roll up your sleeves! 😱

@monatis
Copy link
Owner

monatis commented Mar 11, 2025

Hi @mdhvg, thanks for raising this PR! I'll review it later today and then merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants