chore(compass-components): push toast behind modal COMPASS-8162 #7414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the z-index behavior of toast notifications to display them behind modal dialogs instead of on top. The change addresses COMPASS-8162 by modifying the toast stacking context calculation.
- Updated z-index calculation to position toasts below modal components
- Renamed variables to better reflect the new behavior
- Updated comments to accurately describe the toast positioning
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| const zIndex = stackedContext?.zIndex ? stackedContext.zIndex + 1 : 1; | ||
| // We always want to show the toast under the modal | ||
| const toastPortalStyles = useMemo(() => { | ||
| const zIndex = stackedContext?.zIndex ? stackedContext.zIndex - 1 : 0; |
There was a problem hiding this comment.
Setting z-index to 0 when no stacked context exists may cause toasts to appear behind other page elements. Consider using a positive default value like 1 to ensure toasts remain visible above normal page content.
Suggested change
| const zIndex = stackedContext?.zIndex ? stackedContext.zIndex - 1 : 0; | |
| const zIndex = stackedContext?.zIndex ? stackedContext.zIndex - 1 : 1; |
Copilot uses AI. Check for mistakes.
johnjackweir
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes