feat(eslint): add eslint plugin, add expect method call lint rule COMPASS-10060 #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
commented
Nov 19, 2025
Anemy
commented
Nov 20, 2025
configs/eslint-plugin-devtools/rules/no-expect-method-without-call.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-10060
Description
Adds an eslint plugin packages to
configs.It then adds an eslint rule to the plugin,
no-expect-method-without-callwhich will lint error when a chai expect is used with a method assertion and the method is not called. An example of something that would throw:This is because
includeis intended to be called. We're making this change as we had a lot of.throw/.throwsuses in Compass which weren't testing anything.Adding this in devtools instead of Compass as we'll get some value in all of our tools - mongosh also has an occurence of .throw; Thanks Anna for the suggestion!
In a follow up I'll add anther rule intended to catch passing async methods to these assertions which don't handle promises.