fix/COMPASS-9739 limit collection title to 1 line #156
Conversation
| margin-right: ${spacing[100]}px; | ||
| `; | ||
|
|
||
| export const NodeHeaderTitle = styled.div` |
There was a problem hiding this comment.
The collection name wrap was an intentional change for Relational Migrator - Since we show a relational diagram, these tend to have tables which have identical prefixes (ie: crm_2016_customer_profile, crm_2016_customer_address, etc). We've found that it's more clearer for the customer to have a wrap-around title which fully qualifies the name. Wondering if this particular PR is something which is absolutely needed by Compass? If so we could reach some sort of happy middle ground. cc: @spikefuchaoyuan
See the Figma here: https://www.figma.com/design/326swPiGgJEJN5AqtaslPo/FY26Q1-Small-Design-Stories?node-id=328-17786&m=dev
There was a problem hiding this comment.
Hi @lchans , do you have something in mind for the middle ground? The aim of this is to ensure the node height (and field position) calculation works. It is more important for the field-to-field edges we've switched to, but also the floating edges depend on this when the edge is missing calculatedHeight - leading to flickers as the diagram re-renders.
As an alternative, we could calculate to how many rows the title will span, but this would be much simpler (and probably more future proof)
There was a problem hiding this comment.
@paula-stacho Apologies for not replying earlier - It would be better to keep this functionality in, since this was a decision which was agreed upon by stakeholders (We had a discussion with Julia and Ben) - https://jira.mongodb.org/browse/EXPO-4879 - Could we calculate the span of the row title instead?
External Links
Description
This ensures a consistent node height (avoiding calculations that'd have to account for the length of the title and how it'll wrap when rendered). The full title can still be viewed on hover.
📸 Screenshots/Screencasts
After