chore: add dependency to kerberos MCP-89 #474
Open
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for clients that can use kerberos. It's registered as an optional dependency so clients that can't use kerberos because they don't have the required system dependencies can still use the MCP Server w/o kerberos support.
There was a problem hiding this comment.
Pull Request Overview
This PR adds Kerberos authentication support to the MCP Server by including the kerberos package as an optional dependency. This allows clients with the necessary system dependencies to utilize Kerberos authentication while ensuring the server remains functional for clients without Kerberos support.
- Adds
kerberosas an optional dependency to enable authentication for compatible clients - Maintains backward compatibility for environments without Kerberos system dependencies
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This test requires loading eventual consistent data, and sometimes it returns undefined even if the connection was successful.
kmruiz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for clients that can use kerberos. It's registered as an optional dependency so clients that can't use kerberos because they don't have the required system dependencies can still use the MCP Server w/o kerberos support.
Proposed changes
Checklist