chore: emit close on ConnectionManager #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshusinghs
added
the
no-title-validation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a close event emission capability to the ConnectionManager to support proper cleanup when clients disconnect. The change is part of fixing multiple client connection handling issues in VSCode.
Key changes:
- Adds a new
closeevent to ConnectionManagerEvents interface - Implements a
close()method in MCPConnectionManager that handles disconnection and emits the close event - Refactors Session's disconnect method to use the new close method instead of direct disconnect
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/common/session.ts | Simplifies disconnect method to use ConnectionManager's new close method |
| src/common/connectionManager.ts | Adds close event, implements close method with proper error handling and event emission |
nirinchev
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is part of required changes needed for fixing multiple client connection handling issue on VSCode mongodb-js/vscode#1132.
The idea is for ConnectionManager to emit a
closeevent when the session is being closed which is a signal that a previously connected client has disconnected.The VSCode MCPController will make use of this event to clean up after client disconnects.
Checklist