Skip to content

Conversation

kmruiz
Copy link
Collaborator

@kmruiz kmruiz commented Oct 8, 2025

Proposed changes

This PR adds a new session level service called VectorSearchEmbeddings, that is responsible of:

  1. Understanding if Atlas Search is available
  2. Retrieving which fields of a collection are embeddings, based on Atlas Search index definitions.
  3. Validating that, given a document, it's valid according to the embedding definitions.

Given that the embedding combinations and detection can be inaccurate, we also provide a new configuration option called "disableEmbeddingsValidation" that can be set up by CLI/Env and when true, the validation is bypassed.

This PR also introduces the embedding validation in the insertMany tool, so users can not randomly add data that can break
existing models or indexes unknowingly.

We depend on #628 to be merged, as it implements a method to detect if Atlas Search is available. Whenever the PR is merged, I'll refactor the method introduced there and use VectorSearchEmbeddings, so we have only one single place for search detection.

Checklist

@kmruiz kmruiz self-assigned this Oct 8, 2025
@kmruiz kmruiz marked this pull request as ready for review October 9, 2025 16:01
@kmruiz kmruiz requested a review from a team as a code owner October 9, 2025 16:01
@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 16:01
Copilot

This comment was marked as outdated.

@kmruiz kmruiz marked this pull request as draft October 9, 2025 16:10
@kmruiz kmruiz requested a review from Copilot October 13, 2025 16:35
@kmruiz kmruiz marked this pull request as ready for review October 13, 2025 16:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant