-
Notifications
You must be signed in to change notification settings - Fork 80
chore: bump driver to 6.18.0, bson to 6.10.4 MONGOSH-2413 #2511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates MongoDB Node.js driver dependencies across the codebase, bumping the driver from version 6.16.0 to 6.18.0 and BSON from 6.10.3 to 6.10.4. This is a routine maintenance update to keep dependencies current.
Key changes:
- Upgrade MongoDB driver from ^6.16.0 to ^6.18.0 across all packages
- Upgrade BSON library from ^6.10.3 to ^6.10.4 in relevant packages
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
package.json | Updates root-level MongoDB driver dependency |
packages/types/package.json | Updates MongoDB driver in dev dependencies |
packages/snippet-manager/package.json | Updates BSON dependency |
packages/shell-api/package.json | Updates both MongoDB driver and BSON in dev dependencies |
packages/service-provider-node-driver/package.json | Updates MongoDB driver dependency |
packages/service-provider-core/package.json | Updates both MongoDB driver and BSON dependencies |
packages/node-runtime-worker-thread/package.json | Updates BSON dependency |
packages/e2e-tests/package.json | Updates both MongoDB driver and BSON in dev dependencies |
packages/cli-repl/package.json | Updates MongoDB driver in dev dependencies |
packages/browser-runtime-core/package.json | Updates BSON dependency |
packages/browser-repl/package.json | Updates MongoDB driver in dev dependencies |
packages/arg-parser/package.json | Updates MongoDB driver in dev dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts on the work mentioned in the comments on https://jira.mongodb.org/browse/MONGOSH-2249? I don't think that would be strictly necessary to do as part of the dependency bump PR but it should probably be a close follow-up
@addaleax didn't notice the Jira comment, will try some of it out now |
export function forceCloseMongoClient( | ||
client: MongoClient | ||
): Promise<{ forceClosedConnections: number }> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎉 🎉 🎉 Wooo!!! finally removed!!! 💃🏻 🥳
7e4af75
to
256ed19
Compare
@@ -319,7 +319,7 @@ export default interface Writable { | |||
collection: string, | |||
filter: Document, | |||
update: Document, | |||
options?: UpdateOptions, | |||
options?: UpdateOptions & { sort?: Document }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matches i.e. mongodb/node-mongodb-native@28857b7#diff-1934939aca129a8507697ca1f4354d6fda9d4204d0e06577bd82e33eb6dbfa0bR267
@nbbeeken is there a reason why { sort }
ended up outside of UpdateOptions
but is in ReplaceOptions
?
256ed19
to
b1f7b64
Compare
I don't know why the |
This reverts commit b1f7b64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current code still LGTM, and moving the sort
bit out into a separate PR also seems okay 👍
Bumps the node driver to the latest version.
Pending CI confirmation that no additional adjustments are needed.Seems good.