Skip to content

chore: bump driver to 6.18.0, bson to 6.10.4 MONGOSH-2413 #2511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 1, 2025

Conversation

gagik
Copy link
Contributor

@gagik gagik commented Jul 29, 2025

Bumps the node driver to the latest version.

Pending CI confirmation that no additional adjustments are needed. Seems good.

@gagik gagik changed the title chore: bump node driver to 6.18.0 MONGOSH-2413 chore: bump driver to 6.18.0, bson to 6.10.4 MONGOSH-2413 Jul 29, 2025
@gagik gagik marked this pull request as ready for review July 29, 2025 15:09
@Copilot Copilot AI review requested due to automatic review settings July 29, 2025 15:09
@gagik gagik requested a review from a team as a code owner July 29, 2025 15:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates MongoDB Node.js driver dependencies across the codebase, bumping the driver from version 6.16.0 to 6.18.0 and BSON from 6.10.3 to 6.10.4. This is a routine maintenance update to keep dependencies current.

Key changes:

  • Upgrade MongoDB driver from ^6.16.0 to ^6.18.0 across all packages
  • Upgrade BSON library from ^6.10.3 to ^6.10.4 in relevant packages

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Updates root-level MongoDB driver dependency
packages/types/package.json Updates MongoDB driver in dev dependencies
packages/snippet-manager/package.json Updates BSON dependency
packages/shell-api/package.json Updates both MongoDB driver and BSON in dev dependencies
packages/service-provider-node-driver/package.json Updates MongoDB driver dependency
packages/service-provider-core/package.json Updates both MongoDB driver and BSON dependencies
packages/node-runtime-worker-thread/package.json Updates BSON dependency
packages/e2e-tests/package.json Updates both MongoDB driver and BSON in dev dependencies
packages/cli-repl/package.json Updates MongoDB driver in dev dependencies
packages/browser-runtime-core/package.json Updates BSON dependency
packages/browser-repl/package.json Updates MongoDB driver in dev dependencies
packages/arg-parser/package.json Updates MongoDB driver in dev dependencies

Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thoughts on the work mentioned in the comments on https://jira.mongodb.org/browse/MONGOSH-2249? I don't think that would be strictly necessary to do as part of the dependency bump PR but it should probably be a close follow-up

@gagik
Copy link
Contributor Author

gagik commented Jul 31, 2025

@addaleax didn't notice the Jira comment, will try some of it out now

@gagik gagik force-pushed the gagik/bump-driver branch from 67c95eb to 6ba84fd Compare July 31, 2025 12:35
Comment on lines -4 to -6
export function forceCloseMongoClient(
client: MongoClient
): Promise<{ forceClosedConnections: number }> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉 🎉 Wooo!!! finally removed!!! 💃🏻 🥳

@gagik gagik force-pushed the gagik/bump-driver branch from 7e4af75 to 256ed19 Compare August 1, 2025 13:35
@@ -319,7 +319,7 @@ export default interface Writable {
collection: string,
filter: Document,
update: Document,
options?: UpdateOptions,
options?: UpdateOptions & { sort?: Document },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches i.e. mongodb/node-mongodb-native@28857b7#diff-1934939aca129a8507697ca1f4354d6fda9d4204d0e06577bd82e33eb6dbfa0bR267

@nbbeeken is there a reason why { sort } ended up outside of UpdateOptions but is in ReplaceOptions?

@gagik gagik force-pushed the gagik/bump-driver branch from 256ed19 to b1f7b64 Compare August 1, 2025 14:43
@gagik
Copy link
Contributor Author

gagik commented Aug 1, 2025

I don't know why the sort function doesn't pass on CI... works on my machine. I'll revert that and merge this and follow-up separately

Copy link
Collaborator

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current code still LGTM, and moving the sort bit out into a separate PR also seems okay 👍

@gagik gagik merged commit c8e2697 into main Aug 1, 2025
129 of 139 checks passed
@gagik gagik deleted the gagik/bump-driver branch August 1, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants