Skip to content

fix(deps): bump resolve-mongodb-srv, add trailing dot test MONGOSH-3027 #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
addaleax wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −3
Open

fix(deps): bump resolve-mongodb-srv, add trailing dot test MONGOSH-3027 #2617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31d4a0d
fix(deps): bump resolve-mongodb-srv, add trailing dot test MONGOSH-3027
addaleax Dec 9, 2025
7073064
fixup: test name
addaleax Dec 9, 2025
0b19863
fixup: version with CodeQL enabled
addaleax Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions packages/connectivity-tests/test/atlas.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,18 @@ function test_connection_string() {
check_failed
}

function test_connection_string_fqdn_dot() {
printf "test_connection_string_fqdn_dot ... "

CONNECTION_STRING="mongodb+srv://${ATLAS_USERNAME}:${ATLAS_PASSWORD}@${ATLAS_HOSTNAME}./admin"

echo "${CONNECTION_STATUS_COMMAND}" | "${MONGOSH}" "${CONNECTION_STRING}" |
grep -Fq "${CONNECTION_STATUS_CHECK_STRING}" ||
FAILED="Can't connect to Atlas using connection string with trailing dot"

check_failed
}

function test_atlas_in_logs() {
printf "test_atlas_in_logs ... "

Expand Down Expand Up @@ -144,6 +156,7 @@ function test_srv_without_nodejs_dns() {
}

test_connection_string
test_connection_string_fqdn_dot
test_atlas_in_logs
test_credentials_masking
test_cli_args
Expand Down
Loading