Skip to content

Fix crash when EmbeddedModelArrayField's embedded_model arg is a string #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions django_mongodb_backend/fields/embedded_model_array.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from django.db.models import Field
from django.db.models.fields.related import lazy_related_operation

from .. import forms
from . import EmbeddedModelField
Expand All @@ -12,6 +13,17 @@ def __init__(self, embedded_model, **kwargs):
super().__init__(EmbeddedModelField(embedded_model), **kwargs)
self.embedded_model = embedded_model

def contribute_to_class(self, cls, name, private_only=False, **kwargs):
super().contribute_to_class(cls, name, private_only=private_only, **kwargs)

if not cls._meta.abstract:
# If the embedded_model argument is a string, resolve it to the
# actual model class.
def _resolve_lookup(_, resolved_model):
self.embedded_model = resolved_model

lazy_related_operation(_resolve_lookup, cls, self.embedded_model)

def deconstruct(self):
name, path, args, kwargs = super().deconstruct()
if path == "django_mongodb_backend.fields.embedded_model_array.EmbeddedModelArrayField":
Expand Down
8 changes: 4 additions & 4 deletions tests/model_fields_/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,17 +151,17 @@ def __str__(self):


# EmbeddedModelArrayField
class Review(EmbeddedModel):
class Movie(models.Model):
title = models.CharField(max_length=255)
rating = models.DecimalField(max_digits=6, decimal_places=1)
reviews = EmbeddedModelArrayField("Review", null=True)

def __str__(self):
return self.title


class Movie(models.Model):
class Review(EmbeddedModel):
title = models.CharField(max_length=255)
reviews = EmbeddedModelArrayField(Review, null=True)
rating = models.DecimalField(max_digits=6, decimal_places=1)

def __str__(self):
return self.title
Loading