-
Notifications
You must be signed in to change notification settings - Fork 21
INTPYTHON-355 Add transaction support #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fe4e306
to
5b3b757
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I'll follow up with @blink1073 to discuss running the entire Django test suite on a sharded cluster.
Yeah, the docker image only supports replica sets as I understand it. We maintain a GitHub Action that can start whatever you like, provided you don't need Atlas Search (which requires the docker container): https://github.com/mongodb-labs/drivers-evergreen-tools/blob/master/action.yml You'd set |
d49e282
to
f85ad6c
Compare
Results from sharded cluster tests:
Transaction fc444a97-2534-4c44-9ee3-cba40a215038 - Il1bctjvfYRA0JpLUY4Xle2E6bw+KM1YpMr4x52qGgE= - - :2767 was aborted on statement 8 due to: an error from cluster data placement change :: caused by :: PlanExecutor error during aggregation :: caused by :: Routing info refresh did not complete Someone will have to interpret the meaning.
MongoDB errors with "sharding status of collection test_djangotests.__null is not currently known and needs to be recovered". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(initial comments at #313)
The transactions tests are running via test-python-atlas.yml which uses https://hub.docker.com/r/mongodb/mongodb-atlas-local. I guess it uses a replica set.
Results from testing on a sharded cluster are in my comment below.
fixes #7