Skip to content

Update THIRD-PARTY-NOTICES for django-mongodb-engine #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

Jibola
Copy link
Contributor

@Jibola Jibola commented May 21, 2024

fixes #5

@timgraham
Copy link
Collaborator

For clarity, perhaps the README reference to "Django non-rel's MongoDB Engine" should instead use "django-mongodb-engine" as you've done here.

@timgraham timgraham force-pushed the django-mongodb-engine-license branch from a59f1f6 to caf8b73 Compare June 12, 2024 13:04
@timgraham
Copy link
Collaborator

I copied the format of THIRD-PARTY-NOTICES in PyMongo.

The mongodb-engine repo lacks a LICENSE file. While the README claims "2-clause BSD", I copied the 3-clause BSD from https://github.com/django-nonrel/djangotoolbox/blob/master/LICENSE which is the same as https://github.com/django-nonrel/djangoappengine/blob/master/LICENSE. Possibly we should try to contact the authors and get clarification on this.

@timgraham timgraham requested a review from blink1073 June 12, 2024 13:08
@timgraham timgraham changed the title Update THIRD-PARTY-NOTICES Update THIRD-PARTY-NOTICES for django-mongodb-engine Jun 12, 2024
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@timgraham timgraham merged commit caf8b73 into main Jun 12, 2024
3 checks passed
@timgraham timgraham deleted the django-mongodb-engine-license branch June 12, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add THIRD-PARTY-NOTICES
3 participants