add support for math database functions #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
math-funcs
branch
3 times, most recently
from
d946448 to
dae3e31
Compare
WaVEV
reviewed
Jun 5, 2024
django_mongodb/functions.py
Outdated
| def func(self, compiler, connection): | ||
| lhs_mql = process_lhs(self, compiler, connection) | ||
| try: | ||
| operator = MONGO_OPERATORS[self.__class__] |
There was a problem hiding this comment.
I think it can be done with get:
operator = MONGO_OPERATORS.get(self.__class__, self.function.lower())
Jibola
reviewed
Jun 5, 2024
django_mongodb/features.py
Outdated
| @@ -54,12 +54,20 @@ class DatabaseFeatures(BaseDatabaseFeatures): | |||
| "lookup.tests.LookupTests.test_pattern_lookups_with_substr", | |||
| # Querying ObjectID with string doesn't work. | |||
| "lookup.tests.LookupTests.test_lookup_int_as_str", | |||
| # MongoDB gives the wrong result of log(number, base) when base is a | |||
| # fractional Decimal. | |||
There was a problem hiding this comment.
Suggested change
| # fractional Decimal. | |
| # fractional Decimal. https://jira.mongodb.org/browse/SERVER-91223 |
Jibola
requested changes
Jun 5, 2024
WaVEV
approved these changes
Jun 5, 2024
Jibola
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.