Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-47048: Configure replica set operations #649

Merged
merged 10 commits into from
Mar 27, 2025

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Mar 4, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-47048

Note: this page is very similar to the Scala page, with an added section on sharded clusters

Staging Links

  • crud/read-write-config
  • crud
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Mar 4, 2025

    Deploy Preview for docs-java ready!

    Name Link
    🔨 Latest commit aab6d55
    🔍 Latest deploy log https://app.netlify.com/sites/docs-java/deploys/67e5575e9fce450008e19d9d
    😎 Deploy Preview https://deploy-preview-649--docs-java.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Contributor

    @stephmarie17 stephmarie17 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Nice work! LGTM with a small suggestion.

    Comment on lines 38 to 40
    This list also indicates the increasing order of precedence of the option settings. For
    example, if you set a read concern level for a transaction, it will override a read
    concern level inherited from the client.
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    [s] On initial read, mentioning the precedence levels right before the read concern levels was a little hard to parse, maybe something like this would be clearer:

    Suggested change
    This list also indicates the increasing order of precedence of the option settings. For
    example, if you set a read concern level for a transaction, it will override a read
    concern level inherited from the client.
    This list also indicates the increasing order of precedence of the option settings. For
    example, if you set a read concern level for a transaction, it will override a read
    concern setting inherited from the client.

    @norareidy norareidy marked this pull request as ready for review March 4, 2025 21:52
    @norareidy norareidy requested a review from a team as a code owner March 4, 2025 21:52
    @norareidy norareidy requested review from vbabanin and removed request for a team March 4, 2025 21:52
    @norareidy norareidy requested a review from vbabanin March 21, 2025 15:59
    @norareidy norareidy requested a review from vbabanin March 26, 2025 16:12
    Copy link
    Member

    @vbabanin vbabanin left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good overall!

    Copy link
    Member

    @vbabanin vbabanin left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @norareidy norareidy merged commit 923ac85 into mongodb:master Mar 27, 2025
    5 checks passed
    @norareidy norareidy deleted the DOCSP-47048-replica-set-ops branch March 27, 2025 13:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants