-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-47048: Configure replica set operations #649
DOCSP-47048: Configure replica set operations #649
Conversation
✅ Deploy Preview for docs-java ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM with a small suggestion.
source/crud/read-write-config.txt
Outdated
This list also indicates the increasing order of precedence of the option settings. For | ||
example, if you set a read concern level for a transaction, it will override a read | ||
concern level inherited from the client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[s] On initial read, mentioning the precedence levels right before the read concern levels was a little hard to parse, maybe something like this would be clearer:
This list also indicates the increasing order of precedence of the option settings. For | |
example, if you set a read concern level for a transaction, it will override a read | |
concern level inherited from the client. | |
This list also indicates the increasing order of precedence of the option settings. For | |
example, if you set a read concern level for a transaction, it will override a read | |
concern setting inherited from the client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-47048
Note: this page is very similar to the Scala page, with an added section on sharded clusters
Staging Links
Self-Review Checklist