-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-48687 - Standardize API Source Constants #666
DOCSP-48687 - Standardize API Source Constants #666
Conversation
✅ Deploy Preview for docs-java ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
snooty.toml
Outdated
api-root = "https://mongodb.github.io/mongo-java-driver/{+version+}/apidocs" | ||
client-api = "{+api-root+}/mongodb-driver-sync/com/mongodb/client" | ||
core-api = "{+api-root+}/mongodb-driver-core/com/mongodb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think condensing these into just the following is sufficient.
api-root = "https://mongodb.github.io/mongo-java-driver/{+version+}/apidocs" | |
client-api = "{+api-root+}/mongodb-driver-sync/com/mongodb/client" | |
core-api = "{+api-root+}/mongodb-driver-core/com/mongodb" | |
driver-api = "https://mongodb.github.io/mongo-java-driver/{+version+}/apidocs/mongodb-driver-sync/com/mongodb" | |
core-api = "https://mongodb.github.io/mongo-java-driver/{+version+}/apidocs/mongodb-driver-core/com/mongodb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed to driver-api
. kept other pieces after discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The organization of the source constants lgtm thanks for the collaboration! Mainly checked to see if the API docs drawer was working as expected and selected a few random pages to test links.
(cherry picked from commit 6f002e7)
(cherry picked from commit 6f002e7) Co-authored-by: Mike Woofter <[email protected]>
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48687
Staging Links
Self-Review Checklist