chore(test): exclude deprecated packages from tests #3207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephl3
requested review from
Copilot and
tsck
and removed request for
a team
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the test configuration to exclude deprecated packages from the test suite and regenerates the package list to include a missing component.
Key changes:
- Updates Jest configuration to ignore tests in
/deprecated-packages/directory - Regenerates
ALL_PACKAGES.tsto include the missing@leafygreen-ui/compound-component - Adds eslint disable comment for deprecated package test that doesn't follow current conventions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/test/config/react17/jest.config.js | Adds /deprecated-packages/ to testPathIgnorePatterns |
| tools/test/config/jest.config.js | Adds /deprecated-packages/ to testPathIgnorePatterns |
| tools/install/src/ALL_PACKAGES.ts | Adds missing @leafygreen-ui/compound-component package |
| packages/emotion/src/version.ts | Updates version from 5.0.2 to 5.0.3 |
| deprecated-packages/box/src/Box.spec.tsx | Adds eslint disable comment for jest/expect-expect |
|
Size Change: 0 B Total Size: 1.59 MB ℹ️ View Unchanged
|
TheSonOfThomp
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR updates test configuration to properly exclude packages in the
deprecated-packagesdirectory.Key changes:
'/deprecated-packages/'totestPathIgnorePatternsin Jest configs for both default and React 17 environmentsALL_PACKAGES.tsto include@leafygreen-ui/compound-component(which was missing)🎟️ Jira ticket: N/A
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
Verify deprecated packages are excluded from tests:
Verify ALL_PACKAGES.ts is correct:
tools/install/src/ALL_PACKAGES.tsincludes@leafygreen-ui/compound-componentVerify compound-component is in the list:
Run full test suite: