-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-4040: Use AppContext switch to disable CSHARP-4040 validation #1825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+189
−0
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
183 changes: 183 additions & 0 deletions
183
tests/MongoDB.Driver.Tests/Linq/Linq3Implementation/Jira/CSharp4040SwitchTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,183 @@ | ||
| /* Copyright 2010-present MongoDB Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using MongoDB.Driver.TestHelpers; | ||
| using FluentAssertions; | ||
| using MongoDB.Bson.Serialization; | ||
| using MongoDB.Bson.Serialization.Conventions; | ||
| using MongoDB.Bson.Serialization.Serializers; | ||
| using MongoDB.Driver.Linq; | ||
| using Xunit; | ||
|
|
||
| namespace MongoDB.Driver.Tests.Linq.Linq3Implementation.Jira; | ||
|
|
||
| public class CSharp4040SwitchTests : LinqIntegrationTest<CSharp4040SwitchTests.ClassFixture>, IDisposable | ||
| { | ||
| static CSharp4040SwitchTests() | ||
| { | ||
| AppContext.SetSwitch("Switch.MongoDB.Driver.DisableDiscriminatorFieldConflictCheck", true); | ||
|
|
||
| var discriminatorConvention = new HierarchicalDiscriminatorConvention("TypeNames"); | ||
|
|
||
| BsonClassMap.RegisterClassMap<C>(cm => | ||
| { | ||
| cm.AutoMap(); | ||
| cm.SetIsRootClass(true); | ||
| cm.SetDiscriminatorIsRequired(true); | ||
| cm.MapMember(x => x.TypeNames).SetShouldSerializeMethod(_ => false); | ||
| cm.SetDiscriminatorConvention(discriminatorConvention); | ||
| }); | ||
| } | ||
|
|
||
| public void Dispose() | ||
| { | ||
| AppContext.SetSwitch("Switch.MongoDB.Driver.DisableDiscriminatorFieldConflictCheck", false); | ||
| } | ||
|
|
||
| public CSharp4040SwitchTests(ClassFixture fixture) | ||
| : base(fixture) | ||
| { | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Documents_should_serializer_as_expected() | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var seralizedDocuments = collection.AsQueryable().As(BsonDocumentSerializer.Instance).ToList(); | ||
|
|
||
| seralizedDocuments.Count.Should().Be(2); | ||
| seralizedDocuments[0].Should().Be("{ _id : 1, TypeNames : ['C', 'D'] }"); | ||
| seralizedDocuments[1].Should().Be("{ _id : 2, TypeNames : ['C', 'D', 'E'] }"); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void OfType_C_should_work() | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .OfType<C>(); | ||
|
|
||
| var stages = Translate(collection, queryable); | ||
| AssertStages(stages, []); | ||
|
|
||
| var results = queryable.ToList(); | ||
| results.Select(x => x.Id).Should().Equal(1, 2); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void OfType_D_should_work() | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .OfType<D>(); | ||
|
|
||
| var stages = Translate(collection, queryable); | ||
| AssertStages(stages, "{ $match : { TypeNames : 'D' } }"); | ||
|
|
||
| var results = queryable.ToList(); | ||
| results.Select(x => x.Id).Should().Equal(1, 2); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void OfType_E_should_work() | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .OfType<E>(); | ||
|
|
||
| var stages = Translate(collection, queryable); | ||
| AssertStages(stages, "{ $match : { TypeNames : 'E' } }"); | ||
|
|
||
| var results = queryable.ToList(); | ||
| results.Select(x => x.Id).Should().Equal(2); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Where_TypeNames_Contains_C_should_work() | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .Where(x => x.TypeNames.Contains("C")); | ||
|
|
||
| var stages = Translate(collection, queryable); | ||
| AssertStages(stages, "{ $match : { TypeNames : 'C' } }"); | ||
|
|
||
| var results = queryable.ToList(); | ||
| results.Select(x => x.Id).Should().Equal(1, 2); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Where_TypeNames_Contains_D_should_work() | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .Where(x => x.TypeNames.Contains("D")); | ||
|
|
||
| var stages = Translate(collection, queryable); | ||
| AssertStages(stages, "{ $match : { TypeNames : 'D' } }"); | ||
|
|
||
| var results = queryable.ToList(); | ||
| results.Select(x => x.Id).Should().Equal(1, 2); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Where_TypeNames_Contains_E_should_work() | ||
| { | ||
| var collection = Fixture.Collection; | ||
|
|
||
| var queryable = collection.AsQueryable() | ||
| .Where(x => x.TypeNames.Contains("E")); | ||
|
|
||
| var stages = Translate(collection, queryable); | ||
| AssertStages(stages, "{ $match : { TypeNames : 'E' } }"); | ||
|
|
||
| var results = queryable.ToList(); | ||
| results.Select(x => x.Id).Should().Equal(2); | ||
| } | ||
|
|
||
| public abstract class C | ||
| { | ||
| public int Id { get; set; } | ||
| public virtual IReadOnlyList<string> TypeNames => ["C"]; | ||
| } | ||
|
|
||
| public class D : C | ||
| { | ||
| public override IReadOnlyList<string> TypeNames => ["C", "D"]; | ||
| } | ||
|
|
||
| public class E : D | ||
| { | ||
| public override IReadOnlyList<string> TypeNames => ["C", "D", "E"]; | ||
| } | ||
|
|
||
| public sealed class ClassFixture : MongoCollectionFixture<C> | ||
| { | ||
| protected override IEnumerable<C> InitialData => | ||
| [ | ||
| new D { Id = 1 }, | ||
| new E { Id = 2 } | ||
| ]; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only slightly different than what the user was doing in their sample code, but the end result is the same.
We can't modify the global serialization configuration the way they do, but we can simulate closely on this one class what they are doing globally.