fix wiremessage oob in case of intmin #2076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvasquez
requested changes
Jun 3, 2025
| @@ -406,7 +406,7 @@ func ReadMsgSectionDocumentSequence(src []byte) (identifier string, docs []bsonc | |||
| // sequence data. | |||
| func ReadMsgSectionRawDocumentSequence(src []byte) (identifier string, data []byte, rem []byte, ok bool) { | |||
| length, rem, ok := readi32(src) | |||
| if !ok || int(length) > len(src) || length-4 < 0 { | |||
| if !ok || int(length) > len(src) || length < 0 || length-4 < 0 { | |||
There was a problem hiding this comment.
Suggest checking length < 4 instead of length < 0 || length-4 < 0 .
We should also add a test for this.
There was a problem hiding this comment.
indeed, seems better
|
@kobrineli I'm closing this PR for the time being. If you're still interested in making the change, please open a new pull request with the suggestion applied. |
prestonvasquez
requested review from
matthewdale
and removed request for
matthewdale
API Change ReportNo changes found! |
prestonvasquez
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't attach GODRIVER task number, 'cause I get 403 forbidden trying to access the project page.
Summary
If
lengthis in range fromINT_MIN(i.e. -2147483648) toINT_MIN+3,length-4 < 0check doesn't work as expected due to integer overflow.Getting too small length leads to check pass and further out of bound access.
Adding an additional check for length being smaller than zero solves the issue.