introduce lombok usage in integrationTest to decrease boilerplate #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stIncMale
reviewed
Jun 27, 2025
build.gradle.kts
Outdated
| @@ -110,7 +114,7 @@ spotless { | |||
| tasks.check { dependsOn(tasks.spotlessApply) } | |||
|
|
|||
| tasks.withType<JavaCompile>().configureEach { | |||
| options.compilerArgs.addAll(listOf("-Xlint:all", "-Werror")) | |||
| options.compilerArgs.addAll(listOf("-Xlint:all,-serial,-processing", "-Werror")) | |||
There was a problem hiding this comment.
I am not at the moment against using Lombok in test code, but I don't like this -serial,-processing change: we should not disable those javac lints in the production code unless there is a good reason for that, and using Lombok in test code is not a good reason.
There was a problem hiding this comment.
I think -Xlint:all -Werror should ONLY be applied to production code, not testing code. I made some minor change to achieve that. Now testing code has more freedom in terms of javac warning, just like we have disabled errorprone for it previously.
NathanQingyangXu
force-pushed
the
introduce-lombok-to-test
branch
from
6778a24 to
6ffc4a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forsee a prospect that lots of boilerplate code is required in future integration testing cases. Seems lombok could be exploited to decrease boilerplate so we could focus more on business logic. Only integration testing module is touched.