improve MongoStatement#executeUpdate #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | MongoSocketWriteTimeoutException | ||
| | MongoTimeoutException | ||
| | MongoExecutionTimeoutException e) { | ||
| throw new SQLTimeoutException(e.getMessage(), e); |
There was a problem hiding this comment.
MongoOperationTimeoutException is the only child class of MongoTimeoutException which has been listed here.
NathanQingyangXu
force-pushed
the
HIBERNATE-40-improve-executeUpdate
branch
from
b6197d7 to
65a017b
Compare
# Conflicts: # src/test/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementTests.java
# Conflicts: # src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java
jyemin
reviewed
Feb 18, 2025
There was a problem hiding this comment.
@NathanQingyangXu I'm confused by this PR. Shouldn't it be stacked on top of #35? Otherwise there will be a lot of duplicated bulkWrite-related code I think.
If #35 is merged first, yeah. If this PR is merged first, #35 would be refactored. The gist is to centralize the bulk write in one single location. To avoid confusion, let me close this PR and re-open it after #35 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/HIBERNATE-40
The implementation is based on bulk write API, paving the way for future batch processing code refactoring.