basic update translation #59

NathanQingyangXu · 2025-03-02T13:23:41Z

https://jira.mongodb.org/browse/HIBERNATE-19

a straightforward PR

src/main/java/com/mongodb/hibernate/internal/translate/TableMutationMqlTranslator.java

src/main/java/com/mongodb/hibernate/internal/translate/mongoast/AstDocument.java

NathanQingyangXu · 2025-03-02T17:53:29Z

src/integrationTest/java/com/mongodb/hibernate/BasicCRUDTests.java

+                            {"update": "books", "updates": [{"q": {"_id": {"$eq": {"$undefined": true}}}, "u": {"$set": {"author": {"$undefined": true}, "publishYear": {"$undefined": true}, "title": {"$undefined": true}}}, "multi": true}]}\
+                            """);
+        }
+    }


to prove that the udpating did happen (not one sinlge insertion with latest state), a good feature of hibernate-testing was used here to verify. Note that by default table mutation static update SQL will include all fields for perf reason (db side redundant updating is relatively cheap than dynamic SQL translating)

I tried annotating Book with @DynamicUpdate, and it just worked, barring the statementInspector.getSqlQueries assertion, of course. Should we add a test for that?

good point. I think we should cover this.

There is also a @DynamicInsert, which won't include fields with null values, so it will align with the null-free insertion case we discussed. I might add it later but not in this PR.

NathanQingyangXu · 2025-03-02T17:55:31Z

src/integrationTest/java/com/mongodb/hibernate/BasicCRUDTests.java

@@ -170,6 +172,46 @@ void testSimpleDeletion() {
        }
    }

+    @Nested
+    class UpdateTests {


@Nested is used to accommodate the future new testing case after optimistic locking feature is taken into consideration, even though currently there is only one testing case in this PR.

src/integrationTest/java/com/mongodb/hibernate/BasicCRUDTests.java

# Conflicts: # src/integrationTest/java/com/mongodb/hibernate/BasicCrudIntegrationTests.java

src/integrationTest/java/com/mongodb/hibernate/BasicCrudIntegrationTests.java

…ationTests.java Co-authored-by: Maxim Katcharov <[email protected]>

src/main/java/com/mongodb/hibernate/internal/translate/AbstractMqlTranslator.java

src/integrationTest/java/com/mongodb/hibernate/BasicCrudIntegrationTests.java

stIncMale · 2025-03-07T03:01:00Z

src/integrationTest/java/com/mongodb/hibernate/BasicCRUDTests.java

+                            {"update": "books", "updates": [{"q": {"_id": {"$eq": {"$undefined": true}}}, "u": {"$set": {"author": {"$undefined": true}, "publishYear": {"$undefined": true}, "title": {"$undefined": true}}}, "multi": true}]}\
+                            """);
+        }
+    }


I tried annotating Book with @DynamicUpdate, and it just worked, barring the statementInspector.getSqlQueries assertion, of course. Should we add a test for that?

src/integrationTest/java/com/mongodb/hibernate/BasicCrudIntegrationTests.java

stIncMale · 2025-03-07T03:11:46Z

The last reviewed commit is e988b33.

katcharov · 2025-03-07T16:13:57Z

I will take myself off as a formal reviewer for now - if a secondary is needed, please do add me once the primary is complete.

…ationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

NathanQingyangXu · 2025-03-07T16:39:56Z

The last reviewed commit is e988b33.

I've finished resolving the comments, so the PR is ready for a new book.

NathanQingyangXu

Finished the first round of reivew comments resolving

stIncMale

The last reviewed commit is 90d7876.

src/integrationTest/java/com/mongodb/hibernate/BasicCrudIntegrationTests.java

src/main/java/com/mongodb/hibernate/internal/translate/AbstractMqlTranslator.java

src/integrationTest/java/com/mongodb/hibernate/BasicCrudIntegrationTests.java

stIncMale

The last reviewed commit is 3c4e08f.

stIncMale

The last reviewed commit is 8803d30.

NathanQingyangXu requested review from jyemin and stIncMale March 2, 2025 13:23

NathanQingyangXu commented Mar 2, 2025

View reviewed changes

src/main/java/com/mongodb/hibernate/internal/translate/TableMutationMqlTranslator.java Show resolved Hide resolved

NathanQingyangXu commented Mar 2, 2025

View reviewed changes

src/main/java/com/mongodb/hibernate/internal/translate/mongoast/AstDocument.java Show resolved Hide resolved

basic updating translation

6bb7138

NathanQingyangXu force-pushed the HIBERNATE-19-basic-update-translation branch from 607c442 to 6bb7138 Compare March 2, 2025 17:52

NathanQingyangXu commented Mar 2, 2025

View reviewed changes

stIncMale reviewed Mar 2, 2025

View reviewed changes

src/integrationTest/java/com/mongodb/hibernate/BasicCRUDTests.java Outdated Show resolved Hide resolved

stIncMale mentioned this pull request Mar 2, 2025

Hibernate batch processing #35

Closed

NathanQingyangXu added 2 commits March 3, 2025 10:01

exclude 'merge' out of this PR scope

9a1fe83

revert back naming changing for BasicCrudTests

bbb6fee

jyemin removed their request for review March 3, 2025 16:19

Merge branch 'main' into HIBERNATE-19-basic-update-translation

ab7c3cf

# Conflicts: # src/integrationTest/java/com/mongodb/hibernate/BasicCrudIntegrationTests.java

katcharov reviewed Mar 5, 2025

View reviewed changes

src/integrationTest/java/com/mongodb/hibernate/BasicCrudIntegrationTests.java Outdated Show resolved Hide resolved

Update src/integrationTest/java/com/mongodb/hibernate/BasicCrudIntegr…

e988b33

…ationTests.java Co-authored-by: Maxim Katcharov <[email protected]>

NathanQingyangXu requested a review from katcharov March 6, 2025 14:03

stIncMale requested changes Mar 7, 2025

View reviewed changes

NathanQingyangXu requested a review from stIncMale March 7, 2025 15:55

katcharov removed their request for review March 7, 2025 16:11

NathanQingyangXu and others added 3 commits March 7, 2025 11:28

Update src/integrationTest/java/com/mongodb/hibernate/BasicCrudIntegr…

c55bde9

…ationTests.java Co-authored-by: Valentin Kovalenko <[email protected]>

add update testing case to test @DynamicUpdate

c6791de

addresses code review comments

90d7876

NathanQingyangXu commented Mar 7, 2025

View reviewed changes

Merge branch 'main' into HIBERNATE-19-basic-update-translation

cb0cd77

stIncMale requested changes Mar 7, 2025

View reviewed changes

changes as per code review comments

3c4e08f

NathanQingyangXu requested a review from stIncMale March 10, 2025 19:38

stIncMale reviewed Mar 11, 2025

View reviewed changes

further code changes as per comments

8803d30

NathanQingyangXu requested a review from stIncMale March 11, 2025 13:24

stIncMale approved these changes Mar 11, 2025

View reviewed changes

NathanQingyangXu merged commit ccca670 into mongodb:main Mar 11, 2025
6 checks passed

NathanQingyangXu deleted the HIBERNATE-19-basic-update-translation branch March 11, 2025 16:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

basic update translation #59

basic update translation #59

NathanQingyangXu commented Mar 2, 2025 •

edited

Loading

NathanQingyangXu Mar 2, 2025 •

edited

Loading

stIncMale Mar 7, 2025

NathanQingyangXu Mar 7, 2025

NathanQingyangXu Mar 2, 2025

stIncMale Mar 7, 2025

stIncMale commented Mar 7, 2025

katcharov commented Mar 7, 2025

NathanQingyangXu commented Mar 7, 2025

NathanQingyangXu left a comment

stIncMale left a comment

stIncMale left a comment

stIncMale left a comment

basic update translation #59

basic update translation #59

Conversation

NathanQingyangXu commented Mar 2, 2025 • edited Loading

NathanQingyangXu Mar 2, 2025 • edited Loading

Choose a reason for hiding this comment

stIncMale Mar 7, 2025

Choose a reason for hiding this comment

NathanQingyangXu Mar 7, 2025

Choose a reason for hiding this comment

NathanQingyangXu Mar 2, 2025

Choose a reason for hiding this comment

stIncMale Mar 7, 2025

Choose a reason for hiding this comment

stIncMale commented Mar 7, 2025

katcharov commented Mar 7, 2025

NathanQingyangXu commented Mar 7, 2025

NathanQingyangXu left a comment

Choose a reason for hiding this comment

stIncMale left a comment

Choose a reason for hiding this comment

stIncMale left a comment

Choose a reason for hiding this comment

stIncMale left a comment

Choose a reason for hiding this comment

NathanQingyangXu commented Mar 2, 2025 •

edited

Loading

NathanQingyangXu Mar 2, 2025 •

edited

Loading