Fail if the product is used with an unsupported MongoDB version #79
Conversation
stIncMale
force-pushed
the
checkVersionShouldTrow
branch
from
cfb7815 to
01c60f3
Compare
|
|
||
| import java.sql.Connection; | ||
| import java.sql.DatabaseMetaData; | ||
| import java.sql.ResultSet; | ||
|
|
||
| final class MongoDatabaseMetaData implements DatabaseMetaDataAdapter { | ||
|
|
||
| public static final String MONGO_DATABASE_PRODUCT_NAME = "MongoDB"; | ||
| public static final String MONGO_JDBC_DRIVER_NAME = "MongoDB Java Driver JDBC Adapter"; |
There was a problem hiding this comment.
I needed to use MONGO_DATABASE_PRODUCT_NAME in MongoDialect, but did not want to make MongoDatabaseMetaData public, so I moved the constants to MongoConstants, which seems appropriate.
stIncMale
force-pushed
the
checkVersionShouldTrow
branch
from
01c60f3 to
fd9cc24
Compare
| when(info.getDatabaseMinorVersion()).thenReturn(3); | ||
| assertThat(assertThrows(RuntimeException.class, () -> new MongoDialect(info)) | ||
| .getMessage()) | ||
| .isEqualTo("The minimum supported version of MongoDB is 6.0, but you are using 5.3"); |
There was a problem hiding this comment.
There is more idiomatic assertj usage when it comes to exception assertion, e.g.
assertThatThrownBy(() -> new MongoDialect(info)).isInstanceOf(RuntimeException.class)
.hasMessage("The minimum supported version of MongoDB is 6.0, but you are using 5.3");
| } | ||
| var minimumVersion = getMinimumSupportedVersion(); | ||
| if (version.isBefore(minimumVersion)) { | ||
| throw new RuntimeException(format( |
There was a problem hiding this comment.
Not sure whether we can throw better runtime exception than RuntimeException. Might need to look into Hibernate codebase to explore (e.g. https://github.com/hibernate/hibernate-orm/tree/main/hibernate-community-dialects).
Also, there could be slim possiiblity that RuntimeException thrown here might not end up with Hibernate bootstrapping failure (our intention) but swallowed internally (like the default dialect constructor usage when metadata info is not accessible), so maybe it is an idea to add an integration testing case to prove that this RuntimeException would work as expected.
No description provided.