PYTHON-4206 - QE Range Protocol V2 #1670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
reviewed
Jun 11, 2024
pymongo/asynchronous/encryption.py
Outdated
| @@ -836,7 +831,7 @@ async def encrypt( | |||
| when the algorithm is :attr:`Algorithm.INDEXED`. An integer value | |||
| *must* be given when the :attr:`Algorithm.INDEXED` algorithm is | |||
| used. | |||
| :param range_opts: Experimental only, not intended for public use. | |||
| :param range_opts: Index options for `range` queries. | |||
There was a problem hiding this comment.
We need notes in the docstrings for the new public parameter being added.
There was a problem hiding this comment.
For trimFactor? Or for all of the rangeOpts themselves?
Jibola
approved these changes
Jun 12, 2024
ShaneHarvey
reviewed
Jun 12, 2024
|
|
||
| def __init__( | ||
| self, | ||
| sparsity: int, | ||
| trim_factor: int, |
There was a problem hiding this comment.
Making this a required argument is a breaking change. Is that intended? Are users expected to always specifiy trim_factor?
There was a problem hiding this comment.
Yeah, as per the spec, trim_factor is a required argument.
There was a problem hiding this comment.
I'm not sure that is the case. Adrian says:
My understanding is that [trimFactor is] a knob for our tech support to debug performance issues and that average users should not touch it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.