Skip to content

RUBY-3652 Remove serverless testing #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jamis
Copy link
Contributor

@jamis jamis commented Jul 21, 2025

Remove all testing of serverless (per DRIVERS-3115).

@jamis jamis requested a review from a team as a code owner July 21, 2025 19:58
@jamis jamis requested a review from comandeo-mongo July 21, 2025 19:58
comandeo-mongo
comandeo-mongo previously approved these changes Aug 19, 2025
@Copilot Copilot AI review requested due to automatic review settings August 19, 2025 14:14
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes all serverless testing functionality from the MongoDB Ruby driver per DRIVERS-3115. This includes removing serverless-specific methods, test configurations, and CI/CD infrastructure.

  • Removes the serverless? method and related serverless detection logic
  • Updates test requirements to handle deprecated serverless specifications
  • Removes serverless-related CI/CD tasks and environment variables

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
spec/support/spec_config.rb Removes serverless detection method and adds deprecation wrapper
spec/runners/unified/test.rb Removes serverless-specific error handling for killAllSessions
spec/runners/crud/requirement.rb Adds deprecation support for serverless requirements in test specs
spec/runners/crud.rb Updates test skipping logic for serverless requirements
.evergreen/run-tests-atlas-full.sh Replaces SERVERLESS environment variable with KILL_ALL_SERVER_SESSIONS
.evergreen/config/common.yml.erb Removes serverless task groups and related CI infrastructure
.evergreen/config.yml Removes serverless task groups and related CI infrastructure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

if @serverless && @serverless != :forbid
warn "The `serverless` requirement is deprecated."
end
end
Copy link
Preview

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The condition @serverless && @serverless != :forbid could be simplified to @serverless && @serverless != :forbid or extracted to a more descriptive method like should_warn_about_serverless? for better readability.

Suggested change
end
if should_warn_about_serverless?
warn "The `serverless` requirement is deprecated."
end
end
def should_warn_about_serverless?
@serverless && @serverless != :forbid
end

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants