Skip to content

CLOUDP-329797: Make atlas config init alias of atlas auth login #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cveticm
Copy link
Collaborator

@cveticm cveticm commented Jul 16, 2025

Proposed changes

As these commands are under different parent commands, this is achieved by calling the Login Builder in the Init Builder and setting different Use and Example values.

This results in atlas config init running exactly the same as atlas auth login while still referring to the command correctly as atlas config init in help text.

Changes since last review

  • atlas config init is marked as deprecated
  • adjusted commonerror message for 401 unauthorized errors to remove mention of atlas config innit

Jira ticket: CLOUDP-329797

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

@cveticm cveticm requested review from a team as code owners July 16, 2025 15:42
@github-actions github-actions bot added the need-doc-review Improvements or additions to documentation, will be reviewed by the docs team label Jul 16, 2025
Copy link
Contributor

APIx Bot :bowtie:: a message has been sent to Docs Slack channel 🚀.

Copy link

@ytineo-mongodb ytineo-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Use: "init",
Short: "Configure a profile to store access settings for your MongoDB deployment.",
Example: ` # To configure the tool to work with Atlas:
cmd := auth.LoginBuilder()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are doing this, does it make sense to deprecate this command?

@cveticm cveticm force-pushed the CLOUDP-329797_atlas_config_init_alias branch from 25a05ba to 4d7eac0 Compare July 23, 2025 09:11
@cveticm cveticm requested a review from fmenezes July 23, 2025 09:16
@cveticm
Copy link
Collaborator Author

cveticm commented Jul 23, 2025

e2e failing is flaky plugin tests

Copy link
Contributor

Coverage Report 📈

Branch Commit Coverage
SA_refactor_feature_branch 7f4bec6 25.9%
CLOUDP-329797_atlas_config_init_alias 4d7eac0 25.9%
Difference 0%

@cveticm cveticm merged commit f73c8a8 into SA_refactor_feature_branch Jul 23, 2025
18 of 19 checks passed
@cveticm cveticm deleted the CLOUDP-329797_atlas_config_init_alias branch July 23, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-doc-review Improvements or additions to documentation, will be reviewed by the docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants