-
Notifications
You must be signed in to change notification settings - Fork 89
CLOUDP-329797: Make atlas config init
alias of atlas auth login
#4044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-329797: Make atlas config init
alias of atlas auth login
#4044
Conversation
APIx Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Use: "init", | ||
Short: "Configure a profile to store access settings for your MongoDB deployment.", | ||
Example: ` # To configure the tool to work with Atlas: | ||
cmd := auth.LoginBuilder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are doing this, does it make sense to deprecate this command?
25a05ba
to
4d7eac0
Compare
e2e failing is flaky plugin tests |
Proposed changes
As these commands are under different parent commands, this is achieved by calling the Login Builder in the Init Builder and setting different Use and Example values.
This results in
atlas config init
running exactly the same asatlas auth login
while still referring to the command correctly asatlas config init
in help text.Changes since last review
atlas config init
is marked as deprecatedatlas config innit
Jira ticket: CLOUDP-329797
Checklist
make fmt
and formatted my code