-
Notifications
You must be signed in to change notification settings - Fork 94
CLOUDP-332646: fix structured logging using desugared logger #2532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96e63e2
to
b58742c
Compare
andrpac
approved these changes
Jul 21, 2025
helderjs
approved these changes
Jul 21, 2025
roothorp
approved these changes
Jul 21, 2025
merging as we know cloud-qa is flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#2525 introduced structured logging output.
However, this internally uses the sugared logger which does not take key value pairs and renders a msg field only.
This needs to use the desugar'ed logger to properly render output the url and diff fields separately:
This now properly works with a structured logging tool as well:
Proof of Work
unit tests still apply
Checklist
Reminder (Please remove this when merging)