fix: use correct namespace for password secret #1581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limwa
requested review from
mircea-cosbuc,
lsierant,
slaskawi,
nammn and
Julien-Ben
as code owners
|
Regarding the problem with the connection string secret being garbage-collected when the operator is not deployed cluster-wide, as described in #1578, this PR doesn't fix that problem, because it is unrelated to the logic changed in this PR. I can open another issue later for that problem. EDIT: I've opened #1582 to mitigate this issue. |
legal90
referenced
this pull request
Jul 8, 2024
|
Thank you for submitting this fix, @limwa! Looking forward for MongoDB to review and release it soon :) P.s. I run into the same issue recently, mentioned it here: f904443#r143621651 |
slaskawi
suggested changes
Jul 9, 2024
slaskawi
reviewed
Jul 9, 2024
slaskawi
added
the
safe-to-test
slaskawi
approved these changes
Jul 10, 2024
|
Integrated! Thanks for contribution! |
|
@slaskawi Could you please make a release that includes this bugfix? This is urgently needed🙏 thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1578.
I created this PR because, in our deployment of mongodb-kubernetes-operator at NIAEFEUP, we were having trouble creating the connection string secret in a namespace that was not the one the MDBC resource was deployed to. In particular, as described in the issue, one problem that we encountered was needing to have the password secret in both namespaces (the MDBC resource namespace and the connectionStringSecretNamespace namespace) for the connection string secret to be created. The logic was changed so that the password secret is always looked up in the namespace of the MDBC resource.
As a result, the password secret now only needs to be on the namespace of the MDBC resource (as was expected by the
ensureUserResourcesfunction).All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).