-
Notifications
You must be signed in to change notification settings - Fork 25
Run mongorestore in a tools pod #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
MCK 1.6.0 Release NotesNew Features
Bug Fixes
Other Changes
|
d1c0dbb to
746d5fe
Compare
fa5a487 to
23b5878
Compare
fealebenpae
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good! I especially like the streaming tar solution.
I think the python imports can be optimized, though - we import get_tools_pod several times in the same file, even though there's also a global import. The mongodb_tools_pod import looks unused too.
Summary
This PR moves execution of mongorestore into the tools pod which removes problems with the hostnames and connectivity when executed locally.
Proof of Work
TBD