-
Notifications
You must be signed in to change notification settings - Fork 25
CLOUDP-334392 - Add Delve sidecar for debugging the agent #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
MCK 1.6.0 Release NotesNew Features
Bug Fixes
Other Changes
|
# Conflicts: # scripts/dev/contexts/private-context-template
lsierant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
| @@ -0,0 +1,13 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I'm missing some README.md file that will describe what this image is about, how to use it and how to build it (even though I know it is straightforward)
Summary
This PR removes any code that downloads go & delve at runtime from the agent-launcher script. Instead of enabling debugging of the agent from the script, this is now enabled via the operator. When setting
MDB_AGENT_DEBUGto true in the private context, the operator will add a sidecar which runs delve by attaching to the agent's process.Instructions for using can be found in our wiki.
Proof of Work
This is a local development improvement. It can be checked by adding the env variable to the context and seeing the delve sidecar running.
Checklist
skip-changeloglabel if not needed