feat: Add SendUserProvidedResourceTags to third party integrations resource

[marcabreracast]

Proposed changes

Add SendUserProvidedResourceTags field to third-party-integrations resource.

Link to any related issue(s): CLOUDP-327113

Note: This PR includes breaking changes, due to a needed update of the SDK to be able to populate the SendUserProvidedResourceTags field. Please see comments below addressing the breaking change.

Type of change:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as
  expected)
• This change requires a documentation update
• If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

• cfn invoke for each of CRUDL/cfn test
• Updated resource in example
• Published to AWS private registry
• Used the template in example to create and update a stack in AWS
• Deleted stack to ensure resources are deleted
• Created multiple resources in same stack
• Validated in Atlas UI
• Included screenshots

Required Checklist:

• I have signed the MongoDB CLA
• I have added tests that prove my fix is effective or that my feature works
• I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code
• For CFN Resources: I have released by changes in the private registry and proved by change
  works in Atlas

Screenshots

Atlas UI after resource creation:

[marcabreracast]

This update is needed in order to implement SendUserProvidedResourceTags field.

[marcabreracast]

scheme field attribute is removed in more recent versions of the SDK. See this Terraform PR where this same field is removed and is addressed as a breaking change.

[marcabreracast]

Organization contract test is failing, this is not related to this PR

[EspenAlbert]

Same comments as above

[marcabreracast]

Addressed in 881a029

[marcabreracast]

I just realized, that if I use integrations == nil {}, here, then when results := integrations.GetResults() would panic right? Shouldn't it be integrations != nil instead?

[Copilot]

Pull Request Overview

This PR adds the SendUserProvidedResourceTags field to the third-party integrations resource, allowing users to configure whether user-defined resource tags are included when sending metrics and alerts to third-party services. The implementation includes breaking changes due to an SDK upgrade and removal of the deprecated Scheme field for Prometheus integrations.

• Adds SendUserProvidedResourceTags boolean field to the third-party integration schema
• Updates SDK from v20231115002 to v20250312005 (breaking change)
• Removes deprecated Scheme field from Prometheus integration configuration

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
mongodb-atlas-thirdpartyintegration.json	Adds new field definition and removes deprecated Scheme field
cmd/resource/resource.go	Updates SDK usage and implements field handling logic
cmd/resource/model.go	Updates data model to include new field and remove Scheme
docs/README.md	Updates documentation to reflect schema changes
examples/thirdpartyintegrations/datadog.json	Demonstrates usage of new field
test/*.json	Updates test templates to reflect schema changes

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The comparison apiError.Error == http.StatusConflict is incorrect. apiError.Error is likely an integer status code, but http.StatusConflict is also an integer (409). However, the comparison should use *apiError.ErrorCode or similar field that contains the HTTP status code, not apiError.Error directly.

Suggested change

	if apiError, ok := admin.AsError(err); ok && apiError.Error == http.StatusConflict {
	if apiError, ok := admin.AsError(err); ok && apiError.ErrorCode == http.StatusConflict {

[AgustinBettati]

While we dont have this standarized in CFN, since we have a breaking change (removal of scheme) would suggest adding a small changelog file similar to https://github.com/mongodb/mongodbatlas-cloudformation-resources/blob/master/cfn-resources/access-list-api-key/CHANGELOG.md.

[AgustinBettati]

q: Since we don't have these contract tests running in CI wanted to confirm if you were able to run locally

[AgustinBettati]

once merged would consider if you prefer to handle the release as part of a separate ticket, and consider bumping the major version due to the breaking change

[marcabreracast]

Yeah I think that would be a good idea, due to the breaking change. Currently this resource is on 2.0.0, we can bump to 3.0.0 for the next release.

[lantoli]

Suggested change

	if integrations == nil || len(integrations.GetResults()) == 0 {
	if len(integrations.GetResults()) == 0 {

no need to check integration is not nil, see GetResults implementation:

func (o *PaginatedIntegration) GetResults() []ThirdPartyIntegration {
	if o == nil || IsNil(o.Results) {
		var ret []ThirdPartyIntegration
		return ret
	}
	return *o.Results
}

same for the other ocurrence

[lantoli]

in fact, as you're using results later, instead of retrieving again, you can do something like:

   results := integrations.GetResults()
   if len(results) == 0 {
		return progressevent.GetFailedEventByResponse("No integration returned from create", resModel), nil
	}

	return handler.ProgressEvent{
		OperationStatus: handler.Success,
		ResourceModel:   integrationToModel(*currentModel, &results[0]),
	}, nil

[lantoli]

why define vars res and err separated instead of using := here?

res, err := client.AtlasSDK.ThirdPartyIntegrationsApi.DeleteThirdPartyIntegration(context.Background(), *IntegrationType, *ProjectID).Execute()

[marcosuma]

Agree to bump this to 3.0.0 @marcabreracast can you bring this up to the weekly sync for awareness?

[github-actions]

This PR has gone 30 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 30 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!