test(NODE-7204): migrate node-specific/cursor_stream tests
#4735
+81
−354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
requested changes
Oct 16, 2025
baileympearson
added
the
Primary Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This PR rewrites the integration tests for
node-specific/cursor_stream.Notes for Reviewers
Unfortunately it wasn't possible to simple refactor tests for async/await interface as tests were written quite some time ago, and since nodejs streams support both interfaces (async iterator as well as eventemitter), I decided to rewrite tests. The logic of the tests is the same (insert documents and then stream them back), but organization is different (different describes for both interfaces).
What is the motivation for this change?
This work is part of a larger, ongoing initiative to convert all tests to use
async/await, with the ultimate goal of removing the legacy driver wrapper.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript