[WIP] test(NODE-7179): migrate tests to import directly from src folder
#4736
+450
−445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadjik1
force-pushed
the
NODE-7179
branch
3 times, most recently
from
8158091 to
da062d6
Compare
tadjik1
commented
Oct 17, 2025
|
|
||
| const nextStub = sinon.stub(changeStream.cursor, 'next').callsFake(async function () { | ||
| callback(new MongoNetworkError('error triggered from test')); | ||
| onClose(new MongoNetworkError('error triggered from test')); |
There was a problem hiding this comment.
This is not in the scope if this ticket, but I decided to fix this syntax error, just let me know if I should revert it, no strong feelings.
tadjik1
commented
Oct 17, 2025
|
|
||
| // TODO(NODE-6599): mongodb-legacy adds additional client metadata, breaking these prose tests | ||
| let client: RawMongoClient; | ||
| let client: MongoClient; |
There was a problem hiding this comment.
I guess this is nice side-effect, as we can run these tests w/o wrapper.
There was a problem hiding this comment.
Suggest removing any TODOs related to NODE-6599 as well.
tadjik1
changed the title
src foldersrc folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript