Skip to content

DOP-5371: update css to match finalized designs #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: feat/unified-nav
Choose a base branch
from

Conversation

biancalaube
Copy link
Collaborator

Stories/Links:

DOP-5371

Updates:

  • active tab selection updated
  • Font matching the designs
  • static headers updated
  • docs home button at top of nav
  • update the line seperating the two panels
  • view for one only L1s are shown 
  • width of the sidenav
  • offline snooty button on bottom

should match the double panned designs now

Staging Links:

staging (only loaded the following sites so not all links work: docs-java, docs-c, cloud-docs)

figma

Notes:

  • the updated css is just for the double panned nav, not accordion (mobile/tablet) which i will do in another ticket
  • dark mode i tried to do but there was no examples in the designs. I reached out to lara but she is on OOO but i will update if needed when she gets back

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@biancalaube biancalaube requested review from caesarbell and mmeigs May 7, 2025 20:43
Copy link

netlify bot commented May 7, 2025

Deploy Preview for docs-frontend-stg ready!

Name Link
🔨 Latest commit 4dbbb81
🔍 Latest deploy log https://app.netlify.com/sites/docs-frontend-stg/deploys/68220a0d438015000838ba70
😎 Deploy Preview https://deploy-preview-1411--docs-frontend-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so good!

Let's check with design on the width of the Home button! When you hover, the button is as wide as both panels. I'm wondering if it should only be as wide as the main column or some other height specific to it.

@biancalaube
Copy link
Collaborator Author

@mmeigs , thanks for the comments! They should all be addressed now. Reaching out to Lara now to confirm the behavior on hover for the docs home button

@biancalaube biancalaube requested a review from mmeigs May 12, 2025 14:59
@biancalaube
Copy link
Collaborator Author

@mmeigs I fixed the Docs home button hover behavior in DOP-5372, which is the ticket I am working on right now

@biancalaube biancalaube requested a review from zdw001 May 12, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants