Skip to content

DOP-5664: Skunkworks - Typescriptify some Snooty #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
May 28, 2025
Merged

DOP-5664: Skunkworks - Typescriptify some Snooty #1418

merged 33 commits into from
May 28, 2025

Conversation

mmeigs
Copy link
Collaborator

@mmeigs mmeigs commented May 16, 2025 •
edited
Loading

Stories/Links:

DOP-5664

Staging link

Atlas

Notes:

Converts many files to Typescript

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

mmeigs added 20 commits May 12, 2025 12:19
@mmeigs
Emphasis, CloseButton, constants, use-media, use-presentation-mode, c…
5f00a11 
…ompare-branches-with-version-numbers
@mmeigs
All hooks translated to TS except use-canonical-url and use-remote-me…
24fa28a 
…tadata
@mmeigs
Button, Link, Only, Paragraph, SectionHeader, Text, TitleReference, T…
f512959 
…witter, Transition, find-key-value-pair, BreadcrumbSchema
@mmeigs
Templates (changelog, instruqt, landing, openapi), Spinner, docsTheme
8bddb91
@mmeigs
css module declarations, Templates (product-landing, blank), Ancestor…
c785b38 
… context, dark mode context, image context, page context
@mmeigs
ComponentFactory, Button, ComponentFactoryLazy, Link, Literal, Offlin…
694451a 
…eNotAvailable, format-text, fix page context
@mmeigs
BlockQuote, RightColumn, Root, Rubric, Section, Heading context fixes
ad0da0e
@mmeigs
Code, CodeIO, Input, Code Context, tab context
ddc195d
@mmeigs
renamed Output
e6accc3
@mmeigs
change locale and url-utils names
44042ba
@mmeigs
locale and url-utils, rename DeprecatedVersionSelector and sort=versi…
7fb93c2 
…oned-branches
@mmeigs
realm, useAllDocsets, Select, DeprecatedVersionSelector, sort-version…
4d9c9bd 
…ed-branches
@mmeigs
Describe, Include, Introduction, Kicker, Time, VersionModified
8eea1ac
@mmeigs
Admonition, COmmunityPillLink, Cond
6c61626
@mmeigs
CTA, ChatbotUi, Extract, Glossary, LiteralBlock, MainColumn, more locale
7b85ebf
@mmeigs
update Code snapshot
a9c5ca9
@mmeigs
Fixed most failing tests
96e49ec
@mmeigs
Fix all tests for ts
aebf7ba
@mmeigs
DocsLogo, NoResults, ProductsList, DocsLandingSD, LeafygreenTooltip, …
c5983e6 
…ViewHeader, view-components, feedback constants, useNoScroll, feedback icons
@mmeigs
constants, utils, indexes, whitelist
551f1b8
@netlify Netlify
Copy link

netlify bot commented May 16, 2025 •
edited
Loading

✅ Deploy Preview for docs-frontend-stg ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/projects/docs-frontend-stg/deploys/68376207a6ca1f5e7fc8dc60
😎 Deploy Preview https://deploy-preview-1418--docs-frontend-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mmeigs mmeigs marked this pull request as ready for review May 19, 2025 15:04
rayangler
rayangler reviewed May 21, 2025
View reviewed changes
@mmeigs mmeigs requested a review from rayangler May 28, 2025 14:18
caesarbell
caesarbell reviewed May 28, 2025
View reviewed changes
Copy link
Collaborator

@caesarbell caesarbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some questions, but learned a lot for sure reviewing this PR. Also, there was some pretty cool wins included in here i.e. clean up some CSS logic and switching over to LG's emotion. Thank you for working on this.

@mmeigs mmeigs requested a review from caesarbell May 28, 2025 16:52
caesarbell
caesarbell approved these changes May 28, 2025
View reviewed changes
Copy link
Collaborator

@caesarbell caesarbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for your feedback and replies. I truly have a better understanding now.

@mmeigs mmeigs merged commit 69cd4bd into main May 28, 2025
2 of 6 checks passed
@mmeigs mmeigs deleted the DOP-5664-typescript-skunkworks branch May 28, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarbell caesarbell caesarbell approved these changes

@seungpark seungpark Awaiting requested review from seungpark

@anabellabuckvar anabellabuckvar Awaiting requested review from anabellabuckvar

@rayangler rayangler Awaiting requested review from rayangler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmeigs @caesarbell @rayangler @ASteinheiser