Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-1448: Remove client side limit tracking for cursors #1705

Closed
wants to merge 2 commits into from

Conversation

NathanQingyangXu
Copy link

@NathanQingyangXu NathanQingyangXu commented Oct 30, 2024

https://jira.mongodb.org/browse/DRIVERS-1448

Please complete the following before merging:

  • Update changelog.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

@NathanQingyangXu NathanQingyangXu requested a review from a team as a code owner October 30, 2024 17:21
@NathanQingyangXu NathanQingyangXu requested review from dariakp and ShaneHarvey and removed request for a team October 30, 2024 17:21
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRIVERS-1448 says:

Note: Combining Limit and Batch Size for the Wire Protocol in the CRUD spec can also be removed as part of this ticket.

We should make that change. Also we need to find a spec to mention this change somewhere, likely the crud spec and find_getmore_killcursors_commands.md.

@NathanQingyangXu NathanQingyangXu changed the title Remove client side limit tracking for cursors DRIVERS-1448: Remove client side limit tracking for cursors Oct 30, 2024
@baileympearson
Copy link
Contributor

Any updates on this PR? Node received a user PR today that fixes a small bug in our client-side limit tracking. It would be nice to remove the logic altogether.

@NathanQingyangXu
Copy link
Author

Any updates on this PR? Node received a user PR today that fixes a small bug in our client-side limit tracking. It would be nice to remove the logic altogether.

I am busy with other project, so I am afraid I won't have bandwidth to maintain this. I am gonna close this PR and feel free to take over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants