Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document timeoutMS in collectionOrDatabaseOptions #1775

Merged
merged 4 commits into from
Mar 26, 2025
Merged

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Mar 24, 2025

This was missed in a8a7d01.

Please complete the following before merging:

  • Update changelog.

Intentionally omitting the changelog entry, as the option was already documented in the entry for schema version 1.9.

@jmikola jmikola requested a review from a team as a code owner March 24, 2025 20:04
@jmikola jmikola requested review from alcaeus and removed request for a team March 24, 2025 20:04
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, despite the linter being unhappy. @blink1073 have you encountered this error before?

mdformat.................................................................Failed

  • hook id: mdformat
  • exit code: 1

Error: Could not format
"/home/runner/work/specifications/specifications/source/unified-test-format/unified-test-format.md".

The formatted Markdown renders to different HTML than the input Markdown. This
is likely a bug in mdformat. Please create an issue report here, including the
input Markdown: https://github.com/executablebooks/mdformat/issues

@blink1073
Copy link
Member

It does seem like a bug in mdformat. I tweaked the link until it passed locally. Now I just have to get the indent right lol.

@blink1073
Copy link
Member

All set!

@jmikola jmikola merged commit 5114f7b into master Mar 26, 2025
5 checks passed
@jmikola jmikola deleted the jmikola-patch-2 branch March 26, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants