Validate test files against the schema they declare #1813
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| if [[ $# -lt 2 ]]; then | ||
| echo "Usage: $0 <mode> files" | ||
| echo "Modes:" | ||
| echo " valid: Check that files are valid" | ||
| echo " invalid: Check that files are invalid" | ||
| exit 1 | ||
| fi | ||
|
|
||
| mode=$1 | ||
| shift | ||
|
|
||
| for file in "$@"; do | ||
| schema=$(grep -m 1 "^schemaVersion:" "${file}" | sed -E 's:^schemaVersion\: .*(1\.[0-9]+).*$:\1:') | ||
| minorSchemaVersion=$(echo "${schema}" | sed -E 's:1\.([0-9]+):\1:') | ||
| schemaFile="../schema-${schema}.json" | ||
|
|
||
| if [[ ! -f "${schemaFile}" ]]; then | ||
| echo "Warning: File ${file} specifies an invalid schema ${schema}, using latest instead" | ||
| schemaFile="../schema-latest.json" | ||
| # Latest always uses json-schema draft-2019-09 | ||
| spec="draft2019" | ||
| elif [[ "${minorSchemaVersion}" -gt "23" ]]; then | ||
| # Starting with 1.24, the schema uses draft-2019-09 | ||
| spec="draft2019" | ||
| else | ||
| # Versions up to 1.23 use draft-7 | ||
| spec="draft7" | ||
| fi | ||
|
|
||
| ajv test --spec ${spec} -s "${schemaFile}" -d "${file}" --${mode} | ||
| done |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unified-tests.yml Github action runs both
makeandcheck_schema_version.sh, which seems redundant. What is the difference between those two scripts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um, yeah. check_schema_version.sh indeed handles the exact same thing we're doing here - with that in mind this PR definitely isn't necessary, but we should remove the double checks. I'll follow up on this.