This repository was archived by the owner on Oct 4, 2021. It is now read-only.
[Core][Tests] Add basic ProgressMonitor tests #7255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slluis
reviewed
Feb 27, 2019
| Assert.That (mainTask.Progress, Is.EqualTo (expectedMainProgress).Within (taskProgressTestPrecision)); | ||
| Assert.That (monitor.Progress, Is.EqualTo (expectedMainProgress).Within (taskProgressTestPrecision)); | ||
|
|
||
| monitor.EndTask (); |
There was a problem hiding this comment.
There should be a Step() call after EndTask()
There was a problem hiding this comment.
That's a main part of the problem I described in #7256, in order to reflect child progress in the monitor, this step should not be required and is not obvious. If this is required, we need to find a way to synchronize that.
|
Can we add the non-failing tests to master and keep the failing one in this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more tests for progress monitors. Some tests are based on assumptions that are not necessarily right and need clarification. See: #7256.