[draft] Handle programatic as well as declarative instrumentation and scopes #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prasad Mujumdar <[email protected]>
oi-raanne
requested changes
Mar 4, 2025
|
|
||
| CHAT_SCOPE_NAME = "chat" | ||
| custom_exporter = CustomConsoleSpanExporter() | ||
| @pytest.fixture(scope="module") | ||
| def setup(): | ||
| os.environ[SCOPE_CONFIG_PATH] = os.path.join(os.path.dirname(os.path.abspath(__file__)), SCOPE_METHOD_FILE) | ||
| os.environ[CONFIG_FILE_PATH] = os.path.join(os.path.dirname(os.path.abspath(__file__)), CONFIG_FILE_NAME) |
There was a problem hiding this comment.
setup_monocle_telemetry is the entry point for instrumentation.
This file is more like hack way and does not give any intuition on what it does.
Either scopes json be supported as first class as part of setup_monocle_telemetry, if required
| "scope_name": "question" | ||
| } | ||
| ], | ||
| "http_scopoes": [ |
| ], | ||
| "http_scopoes": [ | ||
| { | ||
| "http_header": "client-id", |
There was a problem hiding this comment.
these are flask or some framework specific. It is better they be handled as part of them
oi-raanne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support wrapper methods and scope via programatic options (via setup_monocle_telemetry) as well as declarative option, set via $MONOCLE_CONFIG_PATH/monocle_config.json
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...