replace legacy impl with Poll - #329
Conversation
ff53fe4 to
8189e24
Compare
|
Thank you very much! Please allow me some time to review it! |
|
Could you re-push it and trigger the CI? |
|
You can also saw CI results in https://github.com/loongs-zhang/monoio/commits/dev-refactor-poll |
|
I think the CI fails due to |
|
And another unrelated issue I think about when reading my old PR draft, the latest monoio-macro's test macro seems not work in user code due to some
Maybe we can come about a way to fix and do it in another PR. |
1d38188 to
2e26222
Compare
4c6f450 to
0849775
Compare
ihciah
left a comment
There was a problem hiding this comment.
It's great! Could you by the way fix the clippy warnings to pass CI?
This will bump the MSRV to 1.74, but since 1.74 was published at Nov. 2023, I think it is fine.
https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
5da9ceb to
aaa0422
Compare
Done, but the loongarch64-unknown-linux-gnu nightly fails, track on cross-rs/cross#1640 |

No description provided.