-
Notifications
You must be signed in to change notification settings - Fork 38
Date range selection within a single calendar #23
base: master
Are you sure you want to change the base?
Conversation
|
@spaceribs looks nice |
|
I tested it and it seems to work fine. |
|
👍 |
| else | ||
| return false | ||
| when "range" | ||
| if $scope.model.start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spaceribs you assume that model holds a valid range here.
It's possible to initialise the picker with empty date/range and this line causes an error
|
@spaceribs I think it's not possible to start with noting selected. As I described in the comment on The condition with current day being selected despite the fact that model is neither a |
|
Another problem: It won't happen if range is manually selected (e.g. I select Mar 14th - 15th) and then month is changed it works fine. |
This is still being actively developed, but the idea is to be able to select a range of dates within a single calendar. It deals mainly with the selection logic and returns back a moment.range as a value to ng-model.