Skip to content

Conversation

@hackwaly
Copy link
Contributor

@hackwaly hackwaly commented Mar 7, 2025

There missing a O(1) way to create StringView from String and UTF-16 positions. This PR added a StringView::unsafe_make for that.

@hackwaly hackwaly requested review from Yu-zh and bobzhang March 7, 2025 04:12
@hackwaly hackwaly force-pushed the yuxiang/stringview-unsafe-make branch from 5937256 to 0c7448f Compare March 7, 2025 04:19
@coveralls
Copy link
Collaborator

coveralls commented Mar 7, 2025

Pull Request Test Coverage Report for Build 5582

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 92.535%

Changes Missing Coverage Covered Lines Changed/Added Lines %
string/view.mbt 0 1 0.0%
Totals Coverage Status
Change from base Build 5581: -0.01%
Covered Lines: 6012
Relevant Lines: 6497

💛 - Coveralls

@hackwaly hackwaly force-pushed the yuxiang/stringview-unsafe-make branch from 0c7448f to ac9cadc Compare March 7, 2025 13:59
@peter-jerry-ye
Copy link
Collaborator

There exists charcodes now, so the corresponding one will be named as unsafe_charcodes.

@hackwaly hackwaly closed this May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants